Requiring numpy requirement to 1.5 on master?

Development matplotlib-devel
1

As pointed out in #1650, we have a bug on Python 3.x handling
file-like objects that are UNIX FILEs, but not actual filesystem
files, such as the sockets used for a urllib HTTP request.

[https://github.com/matplotlib/matplotlib/pull/1650](https://github.com/matplotlib/matplotlib/pull/1650)

As Christoph helpfully points out, Numpy has already solved this

problem (since 1.5.0), so it would be easiest to just use their
solution.

For 1.2.x, I think we shouldn't update the Numpy requirement (which

is currently 1.4) – there, I’ll have to port Numpy’s compatibility
functions to our code base. But for master, I’d rather just use
Numpy’s stuff so all of the intricacies of this are handled in one
place.

(And as a detail, it isn't until Numpy 1.7 that a "CloseFile"

function is provided, so even on master, we’re stuck copying some
code over).

Any objections?

Mike
2

As pointed out in #1650, we have a bug on Python 3.x handling file-like
objects that are UNIX FILEs, but not actual filesystem files, such as
the sockets used for a urllib HTTP request.

_png.read_png crashes on Python 3 with urllib.request object by mdboom · Pull Request #1650 · matplotlib/matplotlib · GitHub

As Christoph helpfully points out, Numpy has already solved this problem
(since 1.5.0), so it would be easiest to just use their solution.

For 1.2.x, I think we shouldn't update the Numpy requirement (which is
currently 1.4) -- there, I'll have to port Numpy's compatibility
functions to our code base. But for master, I'd rather just use Numpy's
stuff so all of the intricacies of this are handled in one place.

(And as a detail, it isn't until Numpy 1.7 that a "CloseFile" function
is provided, so even on master, we're stuck copying some code over).

Any objections?

None from me.

Eric

···

On 2013/01/11 5:38 AM, Michael Droettboom wrote:

Mike

------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812

_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
matplotlib-devel List Signup and Options

3

Nope.

···

On Fri, Jan 11, 2013 at 12:33 PM, Eric Firing <efiring@...229...> wrote:

On 2013/01/11 5:38 AM, Michael Droettboom wrote:

As pointed out in #1650, we have a bug on Python 3.x handling file-like
objects that are UNIX FILEs, but not actual filesystem files, such as
the sockets used for a urllib HTTP request.

_png.read_png crashes on Python 3 with urllib.request object by mdboom · Pull Request #1650 · matplotlib/matplotlib · GitHub

As Christoph helpfully points out, Numpy has already solved this problem
(since 1.5.0), so it would be easiest to just use their solution.

For 1.2.x, I think we shouldn't update the Numpy requirement (which is
currently 1.4) -- there, I'll have to port Numpy's compatibility
functions to our code base. But for master, I'd rather just use Numpy's
stuff so all of the intricacies of this are handled in one place.

(And as a detail, it isn't until Numpy 1.7 that a "CloseFile" function
is provided, so even on master, we're stuck copying some code over).

Any objections?

--
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

4

@mdboom - that sounds like roaring agreement to me. :slight_smile:
Lets go for it.

···

On 14 January 2013 20:34, Damon McDougall <damon.mcdougall@…149…> wrote:

On Fri, Jan 11, 2013 at 12:33 PM, Eric Firing <efiring@…876…> wrote:

On 2013/01/11 5:38 AM, Michael Droettboom wrote:

As pointed out in #1650, we have a bug on Python 3.x handling file-like

objects that are UNIX FILEs, but not actual filesystem files, such as

the sockets used for a urllib HTTP request.

https://github.com/matplotlib/matplotlib/pull/1650

As Christoph helpfully points out, Numpy has already solved this problem

(since 1.5.0), so it would be easiest to just use their solution.

For 1.2.x, I think we shouldn’t update the Numpy requirement (which is

currently 1.4) – there, I’ll have to port Numpy’s compatibility

functions to our code base. But for master, I’d rather just use Numpy’s

stuff so all of the intricacies of this are handled in one place.

(And as a detail, it isn’t until Numpy 1.7 that a “CloseFile” function

is provided, so even on master, we’re stuck copying some code over).

Any objections?

Nope.

–

Damon McDougall

http://www.damon-is-a-geek.com

Institute for Computational Engineering Sciences

201 E. 24th St.

Stop C0200

The University of Texas at Austin

Austin, TX 78712-1229

Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,

MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current

with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only – learn more at:

http://p.sf.net/sfu/learnmore_122412

Matplotlib-devel mailing list

Matplotlib-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/matplotlib-devel