remove ipython hack?

Development matplotlib-devel
1

John, Fernando,

Is it OK to remove the hack now? In pyplot.py:

# a hack to keep old versions of ipython working with mpl after bug
# fix #1209354
if 'IPython.Shell' in sys.modules:
     from matplotlib.backends import new_figure_manager, draw_if_interactive, show
else:
     from matplotlib.backends import pylab_setup
     new_figure_manager, draw_if_interactive, show = pylab_setup()

It is not a big deal, but in the interests of simplification and cleanup I would like to remove this (and related lines in backends/__init__.py) if it is ancient and no longer needed.

Eric

2

This was added in 2005 when mpl was at 0.83 and ipython was at 0.6.15,
so yes, it is OK to remove it now. If someone wants to run the latest
mpl, surely they can upgrade ipython.

JDH

···

On 11/4/07, Eric Firing <efiring@...229...> wrote:

John, Fernando,

Is it OK to remove the hack now? In pyplot.py:

# a hack to keep old versions of ipython working with mpl after bug
# fix #1209354

3

Agreed from this side.

Cheers,

f

···

On 11/5/07, John Hunter <jdh2358@...149...> wrote:

On 11/4/07, Eric Firing <efiring@...229...> wrote:
> John, Fernando,
>
> Is it OK to remove the hack now? In pyplot.py:
>
> # a hack to keep old versions of ipython working with mpl after bug
> # fix #1209354

This was added in 2005 when mpl was at 0.83 and ipython was at 0.6.15,
so yes, it is OK to remove it now. If someone wants to run the latest
mpl, surely they can upgrade ipython.

4

Fernando Perez wrote:

···

On 11/5/07, John Hunter <jdh2358@...149...> wrote:

On 11/4/07, Eric Firing <efiring@...229...> wrote:

John, Fernando,

Is it OK to remove the hack now? In pyplot.py:

# a hack to keep old versions of ipython working with mpl after bug
# fix #1209354

This was added in 2005 when mpl was at 0.83 and ipython was at 0.6.15,
so yes, it is OK to remove it now. If someone wants to run the latest
mpl, surely they can upgrade ipython.

Agreed from this side.

Cheers,

f

Fernando,

Thanks. I did it.

Eric