Hello Matplotlib-Devel,
I would like to submit a patch that enables the use of XDG config
directory on FreeBSD, which makes sense for regular users.
The patch is trivial.
Cheers,
Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-XDG-config-path-on-FreeBSD.patch
Type: text/x-diff
Size: 1560 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20170219/13f5fc23/attachment.patch>
Adam,
Thanks for the patch. Would it be possible for you to submit this as a Pull
Request on GitHub:
?
Thanks,
Ryan
On Sun, Feb 19, 2017 at 11:08 AM, <aufc at cock.li> wrote:
Hello Matplotlib-Devel,
I would like to submit a patch that enables the use of XDG config
directory on FreeBSD, which makes sense for regular users.The patch is trivial.
Cheers,
Adam_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel at python.org
Matplotlib-devel Info Page
--
Ryan May
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20170219/aeba58d4/attachment.html>
2017-02-19 11:55 -0700, Ryan May <rmay31 at gmail.com>:
Thanks for the patch. Would it be possible for you to submit this as a Pull
Request on GitHub:
Hi Ryan,
I would prefer not to do it, because I would have to configure GitHub
account for that and I see no benefit to do that ATM. (Considering the
triviality of the patch.)
I decided to go the "patch over email" way, because it is documented in
the Dev Guide [1] and it's simpler and easier for me than PR.
It's also easy and simple for a commiter to apply the patch with:
git am name-of-the.patch
Please tell me if there are any problems with the pathc.
Cheers,
Adam
Adam,
It's fine--PR is just easier for devs because it doesn't require anything
except the web interface. Also, all additions to Matplotlib have to go
through a PR at some point.
Adrian took care of opening the PR, and it's already merged to the master
branch: Use XDG config path on FreeBSD by afvincent · Pull Request #8103 · matplotlib/matplotlib · GitHub
Thanks for the patch!
Ryan
On Sun, Feb 19, 2017 at 12:44 PM, <aufc at cock.li> wrote:
2017-02-19 11:55 -0700, Ryan May <rmay31 at gmail.com>:
> Thanks for the patch. Would it be possible for you to submit this as a
Pull
> Request on GitHub:Hi Ryan,
I would prefer not to do it, because I would have to configure GitHub
account for that and I see no benefit to do that ATM. (Considering the
triviality of the patch.)I decided to go the "patch over email" way, because it is documented in
the Dev Guide [1] and it's simpler and easier for me than PR.It's also easy and simple for a commiter to apply the patch with:
git am name-of-the.patch
Please tell me if there are any problems with the pathc.
Cheers,
Adam[1] http://matplotlib.org/devel/gitwash/patching.html
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel at python.org
Matplotlib-devel Info Page
--
Ryan May
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20170220/6d7a8e6a/attachment.html>
2017-02-20 12:35 -0700, Ryan May <rmay31 at gmail.com>:
It's fine--PR is just easier for devs because it doesn't require anything
except the web interface. Also, all additions to Matplotlib have to go
through a PR at some point.
OK, I'll keep it in mind.
Adrian took care of opening the PR, and it's already merged to the master
branch: Use XDG config path on FreeBSD by afvincent · Pull Request #8103 · matplotlib/matplotlib · GitHub
Great, thank you for taking care of that.
Adam