Patch suggestion

Now done in the attached patch, I also added support for

    > MxNx3 images; as I suspected these are noticeably slower
    > than MxNx4 images but I changed my mind and decided it
    > was worth supporting them.

Great, I just committed this to CVS.

Andrew, if you get a minute to update from CVS, can you make sure that
the PIL changes don't cause a problem for your PIL using mpl scripts?

Thanks!
JDH

John Hunter wrote:

"Nicholas" == Nicholas Young <subs@...211...> writes:

    > Now done in the attached patch, I also added support for
    > MxNx3 images; as I suspected these are noticeably slower
    > than MxNx4 images but I changed my mind and decided it
    > was worth supporting them.

Great, I just committed this to CVS.

Andrew, if you get a minute to update from CVS, can you make sure that
the PIL changes don't cause a problem for your PIL using mpl scripts?

I didn't have much of a check, but image_demo3.py still works.

This may be the apparently-longstanding imshow resizing bug (that I haven't followed), but this demo shows some storage behavior when resizing -- horizontal stretching of the window allows the aspect ratio of the image to change to horizontally stretched, but vertical stretching of the window appears to scale the image to maintain its original aspect ratio.

Cheers!
Andrew

I don't think this is connected to the changes I've made; as I've
changed none of the resizing/streaching/fixed aspect code. I've not
followed any prior discussion (and so don't know why the problem hasn't
been fixed) but if I'm reading it correctly it's fairly clear from the
general imshow code that problem is going to manifest itself.

Nick

···

On Wed, 2005-06-01 at 15:49 -0700, Andrew Straw wrote:

John Hunter wrote:
>>>>>>"Nicholas" == Nicholas Young <subs@...211...> writes:
>
>
> > Now done in the attached patch, I also added support for
> > MxNx3 images; as I suspected these are noticeably slower
> > than MxNx4 images but I changed my mind and decided it
> > was worth supporting them.
>
> Great, I just committed this to CVS.
>
> Andrew, if you get a minute to update from CVS, can you make sure that
> the PIL changes don't cause a problem for your PIL using mpl scripts?

I didn't have much of a check, but image_demo3.py still works.

This may be the apparently-longstanding imshow resizing bug (that I
haven't followed), but this demo shows some storage behavior when
resizing -- horizontal stretching of the window allows the aspect ratio
of the image to change to horizontally stretched, but vertical
stretching of the window appears to scale the image to maintain its
original aspect ratio.