The changes look ok to me so far. It looks to be mostly a re-organization of existing logic and some consolidation of code. My only concerns are the creation of two new functions. Besides the obvious issues with potential namespace collisions in other parts of the code that might do an ‘from cm import *’, my main issue is that these functions are probably really only meant for internal use and should probably start with an underscore. We can always un-underscore them in a later release…
I will do a bit more testing to see if I can break it, but barring that, I will commit a slightly modified version of the patch later today.
P.S. - As for going off-list in my last email, that was an ‘oops’.
On Thu, Jan 6, 2011 at 10:20 AM, Friedrich Romstedt <friedrichromstedt@…149…> wrote:
nice to get a response. It’s not an urgent patch, but should go in
somwhen (imo). If you could take it and verify that it breaks nothing
I would owe you a donut
Here’s the reference:
Notice that in the email from 18 Oct 14:55, I gave the wrong branch on
apparently (not “trunk” branch).
Shall I add it to the bug tracker so that you can assign it maybe to yourself?
I long for a matplotlib GitHub repo … You might use the GitHub
system to review the patch (it’s more readable than a diff file I
guess). Here’s the link:
Feel free to go on-list, I did not snip away at your response so that
the on-list history will be complete.
2011/1/6 Benjamin Root <ben.root@…55…553…>:
On Mon, Jan 3, 2011 at 2:36 PM, Friedrich Romstedt > > > <friedrichromstedt@…55…149…> wrote:
2010/10/19 Friedrich Romstedt <friedrichromstedt@…149…>:
The test suite passes except for some failures on my 10.6 Mac OS X
with yesterday checked-out astraw github repo. I’ll send them in
another thread. Let’s keep tidy There’s more than the symlog
error mentioned by LittleBigBrain on my sys.
The failures are identical with and without the patch.
There has been no response, so I’m resending together with the patch
file. The patch is created by $ git format-patch -1 on my old git
branch from that time, and can be reapplied by:
$ patch -p1 <0001-Fixing-bug-in-mpl.cm.get_cmap.patch
I cannot test it against recent svn because my gcc on Mac OS X went
havoc after restoring the system from Time Machine (the HDD crashed).
Does anybody know what to do when it cannot find even stdarg.h ???
That time the failures of the test suite did not increase by
introducing the change. And it fixes LittleBigBrain’s bug.
Annotations from the git commit are in the patch file. I think it
needs some thinking-through, although I did it carefully, to approve
Btw what happened to the astraw github mirror? The latest commit on
branch “trunk” is from November.
I don’t know why you haven’t gotten a response on this. I have not looked
into it at all though. Is it a patch that needs to go into 1.0.1? If so, I
can make sure it gets there.