markers disappear using 'seaborn-notebook' style in v1.5

Hi,

I just noticed an issue with markers using the 'seaborn-notebook' style
in v1.5. Usual markers like '+' and 'x' are invisible. It comes from the
line 13 in the stylesheet:

    lines.markeredgewidth: 0

https://github.com/matplotlib/matplotlib/blob/v1.5.1/lib/matplotlib/mpl-data/stylelib/seaborn-notebook.mplstyle#L13

Is this intentional or just a typo ? Should I send a (one line) PR ?

I also made a notebook with plots while investigating the issue:
https://gist.github.com/pierre-haessig/7bcceb99257da94a04525011cb2e81c3
It seems that other seeborn styles are not affected.

best,
Pierre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20160526/a6a23054/attachment.html>

Exactly which version of 1.5 are you using and how did you install it? I
thought we fixed that bug (see
https://github.com/matplotlib/matplotlib/issues/5156 and included links).

Tom

···

On Thu, May 26, 2016, 07:54 Pierre Haessig <pierre.haessig at crans.org> wrote:

Hi,

I just noticed an issue with markers using the 'seaborn-notebook' style in
v1.5. Usual markers like '+' and 'x' are invisible. It comes from the line
13 in the stylesheet:

lines.markeredgewidth: 0

https://github.com/matplotlib/matplotlib/blob/v1.5.1/lib/matplotlib/mpl-data/stylelib/seaborn-notebook.mplstyle#L13

Is this intentional or just a typo ? Should I send a (one line) PR ?

I also made a notebook with plots while investigating the issue:
https://gist.github.com/pierre-haessig/7bcceb99257da94a04525011cb2e81c3
It seems that other seeborn styles are not affected.

best,
Pierre
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel at python.org
https://mail.python.org/mailman/listinfo/matplotlib-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20160526/b568e72f/attachment.html>

I think this is a slightly different issue than #5156, and is described
here: https://github.com/matplotlib/matplotlib/issues/4679

···

On Thu, May 26, 2016 at 5:07 AM, Thomas Caswell <tcaswell at gmail.com> wrote:

Exactly which version of 1.5 are you using and how did you install it? I
thought we fixed that bug (see
https://github.com/matplotlib/matplotlib/issues/5156 and included links).

Tom

On Thu, May 26, 2016, 07:54 Pierre Haessig <pierre.haessig at crans.org> > wrote:

Hi,

I just noticed an issue with markers using the 'seaborn-notebook' style
in v1.5. Usual markers like '+' and 'x' are invisible. It comes from the
line 13 in the stylesheet:

lines.markeredgewidth: 0

https://github.com/matplotlib/matplotlib/blob/v1.5.1/lib/matplotlib/mpl-data/stylelib/seaborn-notebook.mplstyle#L13

Is this intentional or just a typo ? Should I send a (one line) PR ?

I also made a notebook with plots while investigating the issue:
https://gist.github.com/pierre-haessig/7bcceb99257da94a04525011cb2e81c3
It seems that other seeborn styles are not affected.

best,
Pierre
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel at python.org
https://mail.python.org/mailman/listinfo/matplotlib-devel

_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel at python.org
https://mail.python.org/mailman/listinfo/matplotlib-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20160526/68b64b74/attachment.html>

Hi Thomas,

Le 26/05/2016 14:07, Thomas Caswell a ?crit :

Exactly which version of 1.5 are you using and how did you install it?
I thought we fixed that bug (see
https://github.com/matplotlib/matplotlib/issues/5156 and included links).

I'm using 1.5.1 from Anaconda (version "np110py27_0"). I'll test the
clean env tomorrow.

Now, looking at the plot embedded in the discussion, I must add that not
all markers disappears.
Those like "d" or "o" with a solid fill are still there. Only 'x' and
'+' disappear.

Also, the "fix" to use lines.markeredgewidth: 1 has the negative side
effect that "d" or "o" are now plotted with an ugly black border...

Pierre

Le 26/05/2016 16:57, Michael Waskom a ?crit :

I think this is a slightly different issue than #5156, and is
described here: https://github.com/matplotlib/matplotlib/issues/4679

Yes, this is it !

I agree with your July 2015 comment:

it would be better to have some *differentiation* between
the width of the edge around a solid marker, which is purely

aesthetic, and

the weight of the line that is used to draw a line-art marker, which

isn't.

best,
Pierre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20160527/5f757f7c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20160527/5f757f7c/attachment.sig>