github reviews

Folks,

When leaving a review via the github API please leave a note so it is
easier to tell if your concerns have been addressed or not.

Tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20170406/4e8ab58f/attachment.html>

Thomas Caswell writes:

When leaving a review via the github API please leave a note so it is
easier to tell if your concerns have been addressed or not.

What's the procedure for requesting a review? I made a pull request
in mpl_finance that's been sitting since January; it's not anything
important and I'm sure it needs work, but I'm not clear how to find
a reviewer who has time and inclination, and how to ask again in
case github didn't send a notification for the first review request
or the notification got lost, so I've just been letting it sit.

        ...Akkana

The squeaky wheel gets the grease. Probably your best bet is to post a
comment in the PR first. We probably just didn't notice it at the time.
Push comes to shove, hop onto the gitter channel or the matplotlib-dev
mailing list and ping there.

Cheers!
Ben Root

···

On Mon, Apr 24, 2017 at 4:45 PM, Akkana Peck <akkana at shallowsky.com> wrote:

Thomas Caswell writes:
> When leaving a review via the github API please leave a note so it is
> easier to tell if your concerns have been addressed or not.

What's the procedure for requesting a review? I made a pull request
in mpl_finance that's been sitting since January; it's not anything
important and I'm sure it needs work, but I'm not clear how to find
a reviewer who has time and inclination, and how to ask again in
case github didn't send a notification for the first review request
or the notification got lost, so I've just been letting it sit.

        ...Akkana
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel at python.org
https://mail.python.org/mailman/listinfo/matplotlib-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20170424/fb674f50/attachment.html>