Color-cycle change broke polar-annotation test

The test lib/matplotlib/tests/test_axes.py:test_polar_annotations is
failing on master. It passes in 0a9e86a but fails in the next commit
8506c33 "Merge branch 'colorcycle' of git://github.com/faucon/matplotlib".

In the image diff, the text and arrow have shifted a little, but
that's probably due to ftfont differences and is allowed by the
comparison. The failing part is the color of the marker, which has
changed from green to blue.

Is this an intended consequence of the color-cycle change?

polar_axes.png

expected-polar_axes.png

failed-diff-polar_axes.png

···

--
Jouni K. Sepp�nen
http://www.iki.fi/jks

Yes, it is consistent with the idea behind the change, which is that generating a plot element with an explicit color specified should not advance the color cycle. The marker is the first plot element with no explicit color, so it should start at the beginning of the cycle, which is blue, not green.

Will you commit the new "expected" png file? Sorry I did not catch this.

Eric

···

On 03/26/2011 11:12 AM, Jouni K. Seppänen wrote:

The test lib/matplotlib/tests/test_axes.py:test_polar_annotations is
failing on master. It passes in 0a9e86a but fails in the next commit
8506c33 "Merge branch 'colorcycle' of git://github.com/faucon/matplotlib".

In the image diff, the text and arrow have shifted a little, but
that's probably due to ftfont differences and is allowed by the
comparison. The failing part is the color of the marker, which has
changed from green to blue.

Is this an intended consequence of the color-cycle change?