version of numpy for matplotlib: wrong test in setupext.py

Hi

I just downloaded numpy 2.0 and there is a test in the setupext.py of matplotlib which says:

     nn = numpy.__version__.split('.')
     if not (int(nn[0]) >= 1 and int(nn[1]) >= 1):

This clearly does NOT work for numpy 2.0.0 since nn[1] is 0....
Please change this.

Eric

Wasn't this already changed in the trunk some time ago?

···

On Wed, Apr 28, 2010 at 7:13 AM, Eric Emsellem <eemselle@...513...> wrote:

Hi

I just downloaded numpy 2.0 and there is a test in the setupext.py of matplotlib
which says:

nn = numpy\.\_\_version\_\_\.split\(&#39;\.&#39;\)
if not \(int\(nn\[0\]\) &gt;= 1 and int\(nn\[1\]\) &gt;= 1\):

This clearly does NOT work for numpy 2.0.0 since nn[1] is 0....
Please change this.

Darren Dale wrote:

···

On Wed, Apr 28, 2010 at 7:13 AM, Eric Emsellem <eemselle@...513...> wrote:
  

Hi

I just downloaded numpy 2.0 and there is a test in the setupext.py of matplotlib
which says:

    nn = numpy.__version__.split('.')
    if not (int(nn[0]) >= 1 and int(nn[1]) >= 1):

This clearly does NOT work for numpy 2.0.0 since nn[1] is 0....
Please change this.
    
Wasn't this already changed in the trunk some time ago?
  

Yes, matplotlib SVN already has this fix, but the latest released version (0.99.1.2) does not. Here is the patch:

  http://matplotlib.svn.sourceforge.net/viewvc/matplotlib?view=rev&revision=8128

Mike

--
Michael Droettboom
Science Software Branch
Operations and Engineering Division
Space Telescope Science Institute
Operated by AURA for NASA