Typo in mplconf

Hello,

I came across a typo in mplconfig.py that results in an error when processing the matplotlib configurations. Attached is a patch.

Ben Root

mplconf_typo.patch (478 Bytes)

I can apply this patch because it is a simple fix, but the larger
question is whether we want to distribute/support the traited config
at all. It seems like this development branch is mostly abandoned.
Any comments Darren, or others?

But in any case as long as we *do* currently have it it is good to fix
these bugs, so thanks for the patch.

JDH

···

On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root <ben.root@...553...> wrote:

Hello,

I came across a typo in mplconfig.py that results in an error when
processing the matplotlib configurations. Attached is a patch.

The traited config stuff was never supported, and has to be turned on
by setting a global in the source code. So I don't think it makes
sense to distribute it. I'm too busy these days to try to support this
feature and make it the default, plus there were issues with
additional overhead due to pkg_resources, traits, and configobj. I
wouldn't be offended if the code was removed from the trunk. (sniffs)

Darren

···

On Sun, Jul 4, 2010 at 9:24 PM, John Hunter <jdh2358@...149...> wrote:

On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root <ben.root@...553...> wrote:

Hello,

I came across a typo in mplconfig.py that results in an error when
processing the matplotlib configurations. Attached is a patch.

I can apply this patch because it is a simple fix, but the larger
question is whether we want to distribute/support the traited config
at all. It seems like this development branch is mostly abandoned.
Any comments Darren, or others?

But in any case as long as we *do* currently have it it is good to fix
these bugs, so thanks for the patch.

Thanks for applying that patch. I should also note that I am still in the process of tracking down another bug that seems to be related to tconfig. One can trigger it using the pydoc utility on a local build and install of matplotlib from svn. An exception gets raised when searching for “mpl_toolkits.mplot3d.axes3d” from the pydoc graphical gui, which seems to do a brute-force examination of the documentation. So it might be triggering unmaintained code.

Ben Root

···

On Sun, Jul 4, 2010 at 8:24 PM, John Hunter <jdh2358@…149…> wrote:

On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root <ben.root@…553…> wrote:

Hello,

I came across a typo in mplconfig.py that results in an error when

processing the matplotlib configurations. Attached is a patch.

I can apply this patch because it is a simple fix, but the larger

question is whether we want to distribute/support the traited config

at all. It seems like this development branch is mostly abandoned.

Any comments Darren, or others?

But in any case as long as we do currently have it it is good to fix

these bugs, so thanks for the patch.

JDH

Do you guys still want a bug report for the tconfig issue, just in case it might be related to Traits in general (I have no clue where the issue is happening)?

Ben

···

On Sun, Jul 4, 2010 at 9:43 PM, Darren Dale <dsdale24@…272…149…> wrote:

On Sun, Jul 4, 2010 at 9:24 PM, John Hunter <jdh2358@…149…> wrote:

On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root <ben.root@…553…> wrote:

Hello,

I came across a typo in mplconfig.py that results in an error when

processing the matplotlib configurations. Attached is a patch.

I can apply this patch because it is a simple fix, but the larger

question is whether we want to distribute/support the traited config

at all. It seems like this development branch is mostly abandoned.

Any comments Darren, or others?

But in any case as long as we do currently have it it is good to fix

these bugs, so thanks for the patch.

The traited config stuff was never supported, and has to be turned on

by setting a global in the source code. So I don’t think it makes

sense to distribute it. I’m too busy these days to try to support this

feature and make it the default, plus there were issues with

additional overhead due to pkg_resources, traits, and configobj. I

wouldn’t be offended if the code was removed from the trunk. (sniffs)

Darren

After some more digging, I think I finally found the source of my issues. I have noticed that there are inconsistencies between the keys and sections listed in the default matplotlib.conf file and in the class MPLConfig(). While in most cases, these inconsistencies are innocuous and do not cause errors, I think there have been a few inadvertent mistakes.

So, I modified one of the programs to produce a list of all the inconstancies that exist, and I will let you guys figure out what needs to be fixed, or what is intentional.

For example, the first item in thee file states that the MPLConfig class do not have the keys “numerix” and “maskedarray”, but the default configuration file does. In addition, the MPLConfig class has the key datapath, but that is not given in the default conf file. (I do recognize that this should probably be expected in this case, I am merely explaining how to interpret the attached file).

The next paragraph states that MPLConfig class defines a section “path”, but it is not found in the default configuration file.

The other lines that I find interesting:
15 (‘preview’ is given in the conf file, but not in the class)

31-32 (‘embed_chars’ is in the default file, but the config class has ‘embed_char_paths’)
35-36 (many keys between the class and the file are similar, but not the same)

The other paragraphs might be interesting, but I hardly know enough to make such determinations.

Ben Root

configIssues.txt (1.47 KB)

···

On Sun, Jul 4, 2010 at 9:47 PM, Benjamin Root <ben.root@…553…> wrote:

On Sun, Jul 4, 2010 at 9:43 PM, Darren Dale <dsdale24@…149…> wrote:

On Sun, Jul 4, 2010 at 9:24 PM, John Hunter <jdh2358@…149…> wrote:

On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root <ben.root@…553…> wrote:

Hello,

I came across a typo in mplconfig.py that results in an error when

processing the matplotlib configurations. Attached is a patch.

I can apply this patch because it is a simple fix, but the larger

question is whether we want to distribute/support the traited config

at all. It seems like this development branch is mostly abandoned.

Any comments Darren, or others?

But in any case as long as we do currently have it it is good to fix

these bugs, so thanks for the patch.

The traited config stuff was never supported, and has to be turned on

by setting a global in the source code. So I don’t think it makes

sense to distribute it. I’m too busy these days to try to support this

feature and make it the default, plus there were issues with

additional overhead due to pkg_resources, traits, and configobj. I

wouldn’t be offended if the code was removed from the trunk. (sniffs)

Darren

Do you guys still want a bug report for the tconfig issue, just in case it might be related to Traits in general (I have no clue where the issue is happening)?

Ben

After some more digging, I think I finally found the source of my
issues. I have noticed that there are inconsistencies between the keys
and sections listed in the default matplotlib.conf file and in the class
MPLConfig(). While in most cases, these inconsistencies are innocuous
and do not cause errors, I think there have been a few inadvertent mistakes.

Ben,

With Darren's permission I went ahead and deleted matplotlib.config from svn (r8495), so it will not appear in the next release unless someone resurrects it. It can always be pulled out of the svn history and updated, if that turns out to be the thing to do. For now, though, I think that it is better to simplify the mpl tree when possible. We have enough work to do to maintain and improve the parts of mpl that are being used.

Eric

···

On 07/05/2010 10:22 AM, Benjamin Root wrote:

So, I modified one of the programs to produce a list of all the
inconstancies that exist, and I will let you guys figure out what needs
to be fixed, or what is intentional.

For example, the first item in thee file states that the MPLConfig class
do not have the keys "numerix" and "maskedarray", but the default
configuration file does. In addition, the MPLConfig class has the key
datapath, but that is not given in the default conf file. (I do
recognize that this should probably be expected in this case, I am
merely explaining how to interpret the attached file).

The next paragraph states that MPLConfig class defines a section "path",
but it is not found in the default configuration file.

The other lines that I find interesting:
    15 ('preview' is given in the conf file, but not in the class)
    31-32 ('embed_chars' is in the default file, but the config class
has 'embed_char_paths')
    35-36 (many keys between the class and the file are similar, but not
the same)

The other paragraphs might be interesting, but I hardly know enough to
make such determinations.

Ben Root

On Sun, Jul 4, 2010 at 9:47 PM, Benjamin Root <ben.root@…553… > <mailto:ben.root@…553…>> wrote:

    On Sun, Jul 4, 2010 at 9:43 PM, Darren Dale <dsdale24@…149… > <mailto:dsdale24@…149…>> wrote:

        On Sun, Jul 4, 2010 at 9:24 PM, John Hunter <jdh2358@…149… > <mailto:jdh2358@…149…>> wrote:
         > On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root > <ben.root@…553… <mailto:ben.root@…553…>> wrote:
         >> Hello,
         >>
         >> I came across a typo in mplconfig.py that results in an
        error when
         >> processing the matplotlib configurations. Attached is a patch.
         >
         > I can apply this patch because it is a simple fix, but the larger
         > question is whether we want to distribute/support the traited
        config
         > at all. It seems like this development branch is mostly
        abandoned.
         > Any comments Darren, or others?
         >
         > But in any case as long as we *do* currently have it it is
        good to fix
         > these bugs, so thanks for the patch.

        The traited config stuff was never supported, and has to be
        turned on
        by setting a global in the source code. So I don't think it makes
        sense to distribute it. I'm too busy these days to try to
        support this
        feature and make it the default, plus there were issues with
        additional overhead due to pkg_resources, traits, and configobj. I
        wouldn't be offended if the code was removed from the trunk.
        (sniffs)

        Darren

    Do you guys still want a bug report for the tconfig issue, just in
    case it might be related to Traits in general (I have no clue where
    the issue is happening)?

    Ben

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first

_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

After some more digging, I think I finally found the source of my

issues. I have noticed that there are inconsistencies between the keys

and sections listed in the default matplotlib.conf file and in the class

MPLConfig(). While in most cases, these inconsistencies are innocuous

and do not cause errors, I think there have been a few inadvertent mistakes.

Ben,

With Darren’s permission I went ahead and deleted matplotlib.config from

svn (r8495), so it will not appear in the next release unless someone

resurrects it. It can always be pulled out of the svn history and

updated, if that turns out to be the thing to do. For now, though, I

think that it is better to simplify the mpl tree when possible. We have

enough work to do to maintain and improve the parts of mpl that are

being used.

Eric

Eric,

No problem, I just noticed that the config directory was removed. And I just discovered that when svn deletes a directory full of .py and pyc files, the .pyc files get left behind and are still accessed by programs like pydoc that walks the directories searching for packages to load.

Anyway, I am more than happy to help prune down the trunk. Extra stuff that isn’t being used just add noise and confusion. Especially to a depth-first debugger like myself…

Ben Root

···

On Mon, Jul 5, 2010 at 3:38 PM, Eric Firing <efiring@…229…> wrote:

On 07/05/2010 10:22 AM, Benjamin Root wrote:

So, I modified one of the programs to produce a list of all the

inconstancies that exist, and I will let you guys figure out what needs

to be fixed, or what is intentional.

For example, the first item in thee file states that the MPLConfig class

do not have the keys “numerix” and “maskedarray”, but the default

configuration file does. In addition, the MPLConfig class has the key

datapath, but that is not given in the default conf file. (I do

recognize that this should probably be expected in this case, I am

merely explaining how to interpret the attached file).

The next paragraph states that MPLConfig class defines a section “path”,

but it is not found in the default configuration file.

The other lines that I find interesting:

15 ('preview' is given in the conf file, but not in the class)
31-32 ('embed_chars' is in the default file, but the config class

has ‘embed_char_paths’)

35-36 (many keys between the class and the file are similar, but not

the same)

The other paragraphs might be interesting, but I hardly know enough to

make such determinations.

Ben Root

On Sun, Jul 4, 2010 at 9:47 PM, Benjamin Root <ben.root@…553… > > mailto:ben.root@...553...> wrote:

On Sun, Jul 4, 2010 at 9:43 PM, Darren Dale <dsdale24@...149... > >     <mailto:dsdale24@...149...>> wrote:
    On Sun, Jul 4, 2010 at 9:24 PM, John Hunter <jdh2358@...149... > >         <mailto:jdh2358@...149...>> wrote:
     > On Sun, Jul 4, 2010 at 4:46 PM, Benjamin Root > >         <ben.root@...553... <mailto:ben.root@...553...>> wrote:
     >> Hello,
     >>
     >> I came across a typo in mplconfig.py that results in an
    error when
     >> processing the matplotlib configurations.  Attached is a patch.
     >
     > I can apply this patch because it is a simple fix, but the larger
     > question is whether we want to distribute/support the traited
    config
     > at all.  It seems like this development branch is mostly
    abandoned.
     > Any comments Darren, or others?
     >
     > But in any case as long as we *do* currently have it it is
    good to fix
     > these bugs, so thanks for the patch.
    The traited config stuff was never supported, and has to be
    turned on
    by setting a global in the source code. So I don't think it makes
    sense to distribute it. I'm too busy these days to try to
    support this
    feature and make it the default, plus there were issues with
    additional overhead due to pkg_resources, traits, and configobj. I
    wouldn't be offended if the code was removed from the trunk.
    (sniffs)
    Darren
Do you guys still want a bug report for the tconfig issue, just in
case it might be related to Traits in general (I have no clue where
the issue is happening)?
Ben

This SF.net email is sponsored by Sprint

What will you do first with EVO, the first 4G phone?

Visit sprint.com/firsthttp://p.sf.net/sfu/sprint-com-first


Matplotlib-devel mailing list

Matplotlib-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/matplotlib-devel


This SF.net email is sponsored by Sprint

What will you do first with EVO, the first 4G phone?

Visit sprint.com/firsthttp://p.sf.net/sfu/sprint-com-first


Matplotlib-devel mailing list

Matplotlib-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/matplotlib-devel