TkAgg backend issues

Andrew_Straw5 · March 8, 2004, 10:41pm

Hi matplotlib developers,

John has rightly directed me to the developers list with the following email. So now, after subscribing, I have a couple of suggestions for the developer of the TkAgg backend. (John Miller?)

PGP.sig (155 Bytes)

···

Begin forwarded message:

From: John Hunter <jdhunter@...5...>
Date: Tue Mar 9, 2004 2:52:33 AM Australia/Adelaide
To: Andrew Straw <strawman@...36...>
Subject: Re: TkAgg backend issues

    > Hi John, A couple more quick notes:

    > 1) It might be very useful to put the following comment in
    > setupext.py in the add_tk_flags section so that idiots
    > like me don't build the TkAgg backend against tk8.4, even
    > though their Tkinter uses 8.3!

    > # Make sure you use the Tk version given by
    > Tkinter.TkVersion # or else you'll build for a wrong
    > version of the Tcl # interpreter (leading to nasty
    > segfaults).

    > 2) It's pretty clear that a lot of the TkAgg stuff was
    > taken directly out of PIL. Therefore, we need to live up
    > to their (not very challenging) license conditions: we
    > have to include their copyright notice and their
    > permissions as specified in Imaging-1.1.x/README.

Looks right to me. Could you email this to the devel list. I don't
maintain the Tk backend so I'd like Todd and the rest of the stsci
crew to take the lead here.

If it's alright with you, matplotlib-devel is the best place for
patches, comments, etc..., since sometimes other people are working on
similar problems and would like to avail themselves of your work and
comments.

Thanks!
JDH

Todd_Miller · March 8, 2004, 11:14pm

Hi matplotlib developers,

John has rightly directed me to the developers list with the following
email. So now, after subscribing, I have a couple of suggestions for
the developer of the TkAgg backend. (John Miller?)

I'm *Todd* Miller. My SF login is jaytmiller.

> From: John Hunter <jdhunter@...5...>
> Date: Tue Mar 9, 2004 2:52:33 AM Australia/Adelaide
> To: Andrew Straw <strawman@...36...>
> Subject: Re: TkAgg backend issues
>

>
> > Hi John, A couple more quick notes:
>
> > 1) It might be very useful to put the following comment in
> > setupext.py in the add_tk_flags section so that idiots
> > like me don't build the TkAgg backend against tk8.4, even
> > though their Tkinter uses 8.3!
>
> > # Make sure you use the Tk version given by
> > Tkinter.TkVersion # or else you'll build for a wrong
> > version of the Tcl # interpreter (leading to nasty
> > segfaults).

OK. I added this to setupext.py. Thanks for the suggestion.

>
> > 2) It's pretty clear that a lot of the TkAgg stuff was
> > taken directly out of PIL.

This was news to me, but Perry confirmed it.

Therefore, we need to live up
> > to their (not very challenging) license conditions: we
> > have to include their copyright notice and their
> > permissions as specified in Imaging-1.1.x/README.
>

Here's what I think we have to include:

···

On Mon, 2004-03-08 at 17:41, Andrew Straw wrote:

Begin forwarded message:

--------------------------------------------------------------------
Software License
--------------------------------------------------------------------

The Python Imaging Library is

By obtaining, using, and/or copying this software and/or its
associated documentation, you agree that you have read, understood,
and will comply with the following terms and conditions:

Permission to use, copy, modify, and distribute this software and its
associated documentation for any purpose and without fee is hereby
granted, provided that the above copyright notice appears in all
copies, and that both that copyright notice and this permission notice
appear in supporting documentation, and that the name of Secret Labs
AB or the author not be used in advertising or publicity pertaining to
distribution of the software without specific, written prior
permission.

SECRET LABS AB AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO
THIS SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS. IN NO EVENT SHALL SECRET LABS AB OR THE AUTHOR BE LIABLE FOR
ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

JDH... do you have any idea where to put it?

Thanks for the feedback,

Todd Miller

--
Todd Miller <jmiller@...31...>

_Perry_Greenfield · March 10, 2004, 3:41pm

> > > 2) It's pretty clear that a lot of the TkAgg stuff was
> > > taken directly out of PIL.

This was news to me, but Perry confirmed it.

By the way, I'd like to thank Andrew Straw for pointing this out.
I originally looked at how PIL handled blitting images to Tkinter
as a possible way of doing it for Chaco/Kiva, and it seemed to
work fine. But it didn't get used for Chaco/Kiva so it sat there
a while (and the license issue "to-do" faded from my memory)
until it I realized that it could be used for matplotlib/Tk/agg
when I gave it to Todd to use. By then I forgot to mention that
it was taken from PIL so I'm glad you noticed that.

Perry