SF.net SVN: matplotlib:[7506] branches/v0_99_maint/lib/matplotlib/lines.py

Ryan,

I don't think these calls should be removed. Would you convert them to
asanyarray() instead? That will preserve the masked arrays.

Darren

···

Log Message:
-----------
Remove calls to np.asarray(). This was breaking the use of masked arrays in calls to set_[x|y]data() and is handled appropriately already by set_data().

Modified Paths:
--------------
branches/v0_99_maint/lib/matplotlib/lines.py

Modified: branches/v0_99_maint/lib/matplotlib/lines.py

--- branches/v0_99_maint/lib/matplotlib/lines.py 2009-08-18 22:18:59 UTC (rev 7505)
+++ branches/v0_99_maint/lib/matplotlib/lines.py 2009-08-19 07:56:33 UTC (rev 7506)
@@ -843,7 +843,6 @@

    ACCEPTS: 1D array
    """

- x = np.asarray(x)
self.set_data(x, self._yorig)

def set\_ydata\(self, y\):

@@ -852,7 +851,6 @@

    ACCEPTS: 1D array
    """

- y = np.asarray(y)
self.set_data(self._xorig, y)

def set\_dashes\(self, seq\):

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Matplotlib-checkins mailing list
Matplotlib-checkins@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-checkins

--
"In our description of nature, the purpose is not to disclose the real
essence of the phenomena but only to track down, so far as it is
possible, relations between the manifold aspects of our experience" -
Niels Bohr

"It is a bad habit of physicists to take their most successful
abstractions to be real properties of our world." - N. David Mermin

"Once we have granted that any physical theory is essentially only a
model for the world of experience, we must renounce all hope of
finding anything like the correct theory ... simply because the
totality of experience is never accessible to us." - Hugh Everett III

Darren,

I couldn’t find a case where those calls weren’t already duplicated when set_data() was called. According to the code, np.asarray() will be called if ma.isMaskedArray() returns false. Am I missing something?

Ryan

···

On Wed, Aug 19, 2009 at 5:35 PM, Darren Dale <dsdale24@…149…> wrote:

Ryan,

I don’t think these calls should be removed. Would you convert them to

asanyarray() instead? That will preserve the masked arrays.


Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma

No, I didn't realize it was called in set_data.

···

On Wed, Aug 19, 2009 at 6:52 PM, Ryan May<rmay31@...149...> wrote:

On Wed, Aug 19, 2009 at 5:35 PM, Darren Dale <dsdale24@...149...> wrote:

Ryan,

I don't think these calls should be removed. Would you convert them to
asanyarray() instead? That will preserve the masked arrays.

Darren,

I couldn't find a case where those calls weren't already duplicated when
set_data() was called. According to the code, np.asarray() will be called
if ma.isMaskedArray() returns false. Am I missing something?