Qt4 backend improvements

Hi all,

I've looked a bit into the Qt4 backend and found some oddities
that might be interesting to change. The Qt4 backend
does not use the Qt4 facilities to create a toolbar but does
it on its own. I changed that and filed a patch at the sourceforge
patch site under patch request ID 1828848 (Qt4 backend improvement).

Working on that I also found a little bug, which I fixed in
patch request ID 1828813 (PyQt4 giving annoying error messages).

Greetings,

Martin

Thanks for these patches. (And thanks for the e-mail -- many of the developers, myself included, don't follow the trackers all that frequently.)

Martin Teichmann wrote:

Hi all,

I've looked a bit into the Qt4 backend and found some oddities
that might be interesting to change. The Qt4 backend
does not use the Qt4 facilities to create a toolbar but does
it on its own. I changed that and filed a patch at the sourceforge
patch site under patch request ID 1828848 (Qt4 backend improvement).

Seems reasonable. I think it would be worth running this by the original developer of the Qt4 backend (I don't know who that is). There may be a reason it was done in the less straightforward way that aren't obvious to you or I (perhaps to ease embedding... just guessing).

Working on that I also found a little bug, which I fixed in
patch request ID 1828813 (PyQt4 giving annoying error messages).

That looks like a good idea. I've made a few modifications to it (since the variable p was also used in the following "else" clause), and committed it in SVN r4178.

Cheers,
Mike

···

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Matplotlib-users mailing list
Matplotlib-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-users

--
Michael Droettboom
Science Software Branch
Operations and Engineering Division
Space Telescope Science Institute
Operated by AURA for NASA

Thanks for these patches. (And thanks for the e-mail -- many of the
developers, myself included, don't follow the trackers all that
frequently.)

I agree. Its great to get patch submissions, and I dont follow the tracker as
closely as I should. Phil Thompson submitted a patch to fix blitting and
other bugs in the qt4 backend in 2006, and I only discovered it applied the
changes last week!

Martin Teichmann wrote:
> Hi all,
>
> I've looked a bit into the Qt4 backend and found some oddities
> that might be interesting to change. The Qt4 backend
> does not use the Qt4 facilities to create a toolbar but does
> it on its own. I changed that and filed a patch at the sourceforge
> patch site under patch request ID 1828848 (Qt4 backend improvement).

Seems reasonable. I think it would be worth running this by the
original developer of the Qt4 backend (I don't know who that is).

Ted Drain for Qt3, James Amundson for the first crack at porting it to Qt4,
and myself.

There
may be a reason it was done in the less straightforward way that aren't
obvious to you or I (perhaps to ease embedding... just guessing).

I don't think we can use the QMainWindow's addToolBar for this. It creates a
single toolbar for the entire window, but what if we want to add two
canveses, each with its own toolbar, in a single window? I am writing an
application that does this.

> Working on that I also found a little bug, which I fixed in
> patch request ID 1828813 (PyQt4 giving annoying error messages).

That looks like a good idea. I've made a few modifications to it (since
the variable p was also used in the following "else" clause), and
committed it in SVN r4178.

Looks like we tried to apply the QPainter patch at the same time. I added a
comment to the CHANGELOG.

Darren

···

On Friday 09 November 2007 08:11:02 am Michael Droettboom wrote: