plotting markers fails with current svn

Hi all,

With the current svn, It fails with the following Exception if I try
to draw markers (I'm using GtkAgg backends and I presume this only
happens with Agg backends). Can others confirm this?

    745 renderer.draw_markers(
    746 gc, Path.unit_circle(), transform, path, path_trans,
--> 747 rgbFace)
    748
    749

ValueError: Codes array is wrong length

And this seems to be due to the error checking code in
"src/agg_py_path_iterator.h" recently introduced by Michael (r6033).
At line 42,

            if (PyArray_DIM(m_codes, 0) != PyArray_DIM(m_vertices, 1))
                throw Py::ValueError("Codes array is wrong length");

I guess the second argument of the PyArray_DIM should be 0 in both cases.

            if (PyArray_DIM(m_codes, 0) != PyArray_DIM(m_vertices, 0))
                throw Py::ValueError("Codes array is wrong length");

Above simple change worked fine for me.

Regards,

-JJ

Jae-Joon Lee wrote:

Hi all,

With the current svn, It fails with the following Exception if I try
to draw markers (I'm using GtkAgg backends and I presume this only
happens with Agg backends). Can others confirm this?

    745 renderer.draw_markers(
    746 gc, Path.unit_circle(), transform, path, path_trans,
--> 747 rgbFace)
    748
    749

ValueError: Codes array is wrong length

And this seems to be due to the error checking code in
"src/agg_py_path_iterator.h" recently introduced by Michael (r6033).
At line 42,

            if (PyArray_DIM(m_codes, 0) != PyArray_DIM(m_vertices, 1))
                throw Py::ValueError("Codes array is wrong length");

I guess the second argument of the PyArray_DIM should be 0 in both cases.

            if (PyArray_DIM(m_codes, 0) != PyArray_DIM(m_vertices, 0))
                throw Py::ValueError("Codes array is wrong length");

Above simple change worked fine for me.

Thank you, I committed the fix.

Eric

···

Regards,

-JJ

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Thanks for catching this. Looks like the correct solution to the error I introduced.

Cheers,
Mike