patch submission procdure

Part of the problem is that I don't have much experience

    > with cvs/svn beyond checking code out. That is why I am
    > asking for a procedure. I also don't know if someone needs
    > to look at what I have done and make sure I am not a total
    > hack (I made some changes to it based on John's feedback).
    > I will in no way be offended if someone wants to look over
    > my shoulder, and I don't mind tweaking it to follow better
    > coding practices or whatever, but I do want to follow it
    > through to getting it included.

The best way is to get a copy of cvs and build your patch with 'cvs
diff' and then post it here and on the sourceforge patches site.

And remind us after a week if we fail to take action!

JDH

John Hunter wrote:

"Ryan" == Ryan Krauss <ryanlists@...149...> writes:

    > Part of the problem is that I don't have much experience
    > with cvs/svn beyond checking code out. That is why I am
    > asking for a procedure. I also don't know if someone needs
    > to look at what I have done and make sure I am not a total
    > hack (I made some changes to it based on John's feedback).
    > I will in no way be offended if someone wants to look over
    > my shoulder, and I don't mind tweaking it to follow better
    > coding practices or whatever, but I do want to follow it
    > through to getting it included.

The best way is to get a copy of cvs and build your patch with 'cvs
diff' and then post it here and on the sourceforge patches site.

And remind us after a week if we fail to take action!

In addition to John's comments, you may want to browse the ipython page on this topic (John, feel free to steal it and tweak it to suit your personal taste):

http://projects.scipy.org/ipython/ipython/wiki/DeveloperGuidelines

While some things there may be specific to IPython (I am _much_ more picky about detailed changelogs than matplotlib is, for example), the bulk of it is generic advice, good for anyone coming to an Open Source Python project.

About the only thing I'd add for mpl would be to make your diffs with 'cvs diff -u', since by default CVS doesn't do that (SVN does, so I removed that bit of advice yesterday). One of these days John will see the light of SVN and this difference will vanish :slight_smile:

[ BTW, John, useful little links I found today on SVN, better than what I'd seen before]:

https://www.projects.dev2dev.bea.com/scdocs/ddUsingSVN_command-line
http://www.developer.com/open/article.php/10930_3499816_1

I hope this is useful.

Cheers,

f