Patch for matplotlib-py3

Hello,

please consider the attached patch for the matplotlib-py3 fork on github. It corrects some build and test failures and removes unnecessary 'extern "C"' statements from PyMODINIT_FUNC functions.

From <http://docs.python.org/release/2.6.6/extending/extending.html>:
Note that PyMODINIT_FUNC declares the function as void return type, declares any special linkage declarations required by the platform, and for C++ declares the function as extern "C".

Christoph

mpl-py3.diff (6.22 KB)

I have added these as pull requests to matplotlib/matplotlib-py3.

To save us all time and make it easier to do code review, you may want to follow the instructions here to create your own pull requests:

http://matplotlib.github.com/devel/gitwash/development_workflow.html

Cheers,
Mike

···

________________________________________
From: Christoph Gohlke [cgohlke@...244...]
Sent: Wednesday, March 16, 2011 3:01 PM
To: matplotlib development list
Subject: [matplotlib-devel] Patch for matplotlib-py3

Hello,

please consider the attached patch for the matplotlib-py3 fork on
github. It corrects some build and test failures and removes unnecessary
'extern "C"' statements from PyMODINIT_FUNC functions.

From <http://docs.python.org/release/2.6.6/extending/extending.html>:
Note that PyMODINIT_FUNC declares the function as void return type,
declares any special linkage declarations required by the platform, and
for C++ declares the function as extern "C".

Christoph

I thought the workflow/process of contributing to matplotlib did not change:

<http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg07849.html>
<http://matplotlib.sourceforge.net/faq/howto_faq.html#contributing-howto>

Christoph

···

On 3/17/2011 6:40 AM, Michael Droettboom wrote:

I have added these as pull requests to matplotlib/matplotlib-py3.

To save us all time and make it easier to do code review, you may want to follow the instructions here to create your own pull requests:

http://matplotlib.github.com/devel/gitwash/development_workflow.html

Cheers,
Mike

________________________________________
From: Christoph Gohlke [cgohlke@...244...]
Sent: Wednesday, March 16, 2011 3:01 PM
To: matplotlib development list
Subject: [matplotlib-devel] Patch for matplotlib-py3

Hello,

please consider the attached patch for the matplotlib-py3 fork on
github. It corrects some build and test failures and removes unnecessary
'extern "C"' statements from PyMODINIT_FUNC functions.

  From<http://docs.python.org/release/2.6.6/extending/extending.html>:
Note that PyMODINIT_FUNC declares the function as void return type,
declares any special linkage declarations required by the platform, and
for C++ declares the function as extern "C".

Christoph

Things are still very much in flux as we get our git legs -- so I didn't mean to imply any sort of "must do". It's not a problem to continue doing what you're doing, you just might see faster service by using github pull requests and the code review facility there is very cool. There's some information on this in the newly updated docs here:

http://matplotlib.github.com/devel/gitwash/patching.html

Cheers,
Mike

···

________________________________________
From: Christoph Gohlke [cgohlke@...244...]
Sent: Thursday, March 17, 2011 12:21 PM
Cc: matplotlib development list
Subject: Re: [matplotlib-devel] Patch for matplotlib-py3

I thought the workflow/process of contributing to matplotlib did not change:

<http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg07849.html>
<http://matplotlib.sourceforge.net/faq/howto_faq.html#contributing-howto>

Christoph

On 3/17/2011 6:40 AM, Michael Droettboom wrote:

I have added these as pull requests to matplotlib/matplotlib-py3.

To save us all time and make it easier to do code review, you may want to follow the instructions here to create your own pull requests:

http://matplotlib.github.com/devel/gitwash/development_workflow.html

Cheers,
Mike

________________________________________
From: Christoph Gohlke [cgohlke@...244...]
Sent: Wednesday, March 16, 2011 3:01 PM
To: matplotlib development list
Subject: [matplotlib-devel] Patch for matplotlib-py3

Hello,

please consider the attached patch for the matplotlib-py3 fork on
github. It corrects some build and test failures and removes unnecessary
'extern "C"' statements from PyMODINIT_FUNC functions.

  From<http://docs.python.org/release/2.6.6/extending/extending.html>:
Note that PyMODINIT_FUNC declares the function as void return type,
declares any special linkage declarations required by the platform, and
for C++ declares the function as extern "C".

Christoph

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel