Patch for errorbar, alpha kw did not apply to lines and cap markers

Development matplotlib-devel
1

Hi matplotlib developers,

this is my first commit to matplotlib. I am using it heavily in a scientific context. I followed the How-to and send you an according patch for what I consider a bug. If it doesn't make sense, please be lenient with me for now, since it my first time. : )

As described in the subject line, I made the alpha keyword in the errorbar command act also on the error bars and not only on the markers. The previous behaviour seemed inconsistent.

Cheers,
Hans

0001-BF-make-alpha-keyword-apply-to-error-lines-and-cap-m.patch (1.2 KB)

2

Hi again,

I send this patch to the mailing list two weeks ago and did not get any response. If you reject it, could you please explain why or how I should improve?

Best regards.

0001-BF-make-alpha-keyword-apply-to-error-lines-and-cap-m.patch (1.2 KB)

···

-------- Original Message --------
Subject: Patch for errorbar, alpha kw did not apply to lines and cap markers
Date: Wed, 06 Jun 2012 17:57:31 +0200
From: Hans Dembinski <hans.dembinski@...1073...>
To: matplotlib-devel@lists.sourceforge.net

Hi matplotlib developers,

this is my first commit to matplotlib. I am using it heavily in a
scientific context. I followed the How-to and send you an according
patch for what I consider a bug. If it doesn't make sense, please be
lenient with me for now, since it my first time. : )

As described in the subject line, I made the alpha keyword in the
errorbar command act also on the error bars and not only on the markers.
The previous behaviour seemed inconsistent.

Cheers,
Hans

3

Our apologies, there aren’t that many of us. I see that you followed our documentation for submitting a patch:

http://matplotlib.sourceforge.net/devel/gitwash/patching.html

Looking at your patch, I think it makes sense to do what you did. I only wonder if there are any other properties that should be taken care of here? Color? Linestyle? etc?

Thoughts?

Cheers!
Ben Root

Note to self: we need to update the docs to describe how to do Pull Requests on GitHub.

···

On Fri, Jun 22, 2012 at 5:58 AM, Hans Dembinski <hans.dembinski@…1073…> wrote:

Hi again,

I send this patch to the mailing list two weeks ago and did not get any response. If you reject it, could you please explain why or how I should improve?

Best regards.

4

Hi!

Thanks for the answer! I think the linestyle and the color settings are ok. error bars that are not just lines look very ugly, i would not even dare to make dashed or dotted ones. the color of the error bars can be set separately with elinecolor while the default is to use the color of the markers.

Cheers,
Hans

···

On 06/22/2012 02:58 PM, Benjamin Root wrote:

On Fri, Jun 22, 2012 at 5:58 AM, Hans Dembinski <hans.dembinski@...1073... > <mailto:hans.dembinski@…1073…>> wrote:

    Hi again,

    I send this patch to the mailing list two weeks ago and did not get
    any response. If you reject it, could you please explain why or how
    I should improve?

    Best regards.

Our apologies, there aren't that many of us. I see that you followed
our documentation for submitting a patch:

http://matplotlib.sourceforge.net/devel/gitwash/patching.html

Looking at your patch, I think it makes sense to do what you did. I
only wonder if there are any other properties that should be taken care
of here? Color? Linestyle? etc?

Thoughts?

Cheers!
Ben Root

Note to self: we need to update the docs to describe how to do Pull
Requests on GitHub.