[PATCH] dysfunction in mpl.cm.get_cmap() (Reporter: LittleBigBrain)

Hi

As discussed recently I have a patch, see
http://github.com/friedrichromstedt/matplotlib/commit/1ac794b362d143ac6a634b70993d950d8fe4adeb
.

I'd like to provide a patch in .patch format for this. But I don't
know how to do this. Is it simply $git format-patch -1?

The test suite passes except for some failures on my 10.6 Mac OS X
with yesterday checked-out astraw github repo. I'll send them in
another thread. Let's keep tidy :slight_smile: There's more than the symlog
error mentioned by LittleBigBrain on my sys.

The failures are identical with and without the patch.

Opinions?

I'm still hesitating to send this to -devel, because this list shall
be better low-traffic I believe, but I think this one definitely is a
devel email :slight_smile:

Friedrich

2010/10/19 Friedrich Romstedt <friedrichromstedt@...149...>:

The test suite passes except for some failures on my 10.6 Mac OS X
with yesterday checked-out astraw github repo. I'll send them in
another thread. Let's keep tidy :slight_smile: There's more than the symlog
error mentioned by LittleBigBrain on my sys.

The failures are identical with and without the patch.

Opinions?

There has been no response, so I'm resending together with the patch
file. The patch is created by $ git format-patch -1 on my old git
branch from that time, and can be reapplied by:

$ patch -p1 <0001-Fixing-bug-in-mpl.cm.get_cmap.patch

I cannot test it against recent svn because my gcc on Mac OS X went
havoc after restoring the system from Time Machine (the HDD crashed).
Does anybody know what to do when it cannot find even stdarg.h ???

That time the failures of the test suite did not increase by
introducing the change. And it fixes LittleBigBrain's bug.

Annotations from the git commit are in the patch file. I think it
needs some thinking-through, although I did it carefully, to approve
it.

Btw what happened to the astraw github mirror? The latest commit on
branch "trunk" is from November.

Friedrich

0001-Fixing-bug-in-mpl.cm.get_cmap.patch (4.52 KB)