[PATCH 0/2] remove unused code

Development matplotlib-devel
1

First ever patch submission. Here I propose cleaning up some unused variables
and imports.

Kelvin Li (2):
  remove unused variable "cmd_split"
  backends: remove unnecessary import statements

lib/matplotlib/backends/backend_agg.py | 2 --
lib/matplotlib/backends/backend_cairo.py | 5 ++--
lib/matplotlib/backends/backend_gdk.py | 9 -------
lib/matplotlib/backends/backend_gtk.py | 7 +++--
lib/matplotlib/backends/backend_gtk3agg.py | 1 -
lib/matplotlib/backends/backend_gtk3cairo.py | 2 --
lib/matplotlib/backends/backend_gtkagg.py | 7 +----
lib/matplotlib/backends/backend_gtkcairo.py | 3 ---
lib/matplotlib/backends/backend_macosx.py | 11 +++-----
lib/matplotlib/backends/backend_mixed.py | 2 --
lib/matplotlib/backends/backend_nbagg.py | 2 --
lib/matplotlib/backends/backend_pgf.py | 2 --
lib/matplotlib/backends/backend_ps.py | 26 +++----------------
lib/matplotlib/backends/backend_qt4.py | 36 ++------------------------
lib/matplotlib/backends/backend_qt4agg.py | 11 --------
lib/matplotlib/backends/backend_qt5agg.py | 9 -------
lib/matplotlib/backends/backend_svg.py | 12 ++++-----
lib/matplotlib/backends/backend_template.py | 4 ---
lib/matplotlib/backends/backend_tkagg.py | 13 +++-------
lib/matplotlib/backends/backend_webagg.py | 1 -
lib/matplotlib/backends/backend_webagg_core.py | 4 ---
lib/matplotlib/backends/backend_wx.py | 2 --
lib/matplotlib/backends/backend_wxagg.py | 9 +++----
lib/matplotlib/backends/tkagg.py | 3 ---
lib/matplotlib/backends/windowing.py | 2 --
lib/matplotlib/texmanager.py | 6 -----
26 files changed, 26 insertions(+), 165 deletions(-)

···

--
2.1.4

2

Kelvin,

Thank you for your work. Would it be possible for you to open a pull request on git hub with these changes (that is where we so almost all of our code review recently and is hooked in to a continuous integration service).

I have not looked at the diff yet (still on my phone), but from looking at the file list I am a bit concerned. The backends have a good number of imports that are there for compatibility reasons.

This might also conflict with the mep27 related pr #4143.

There is also an open pr working on the wx backend that this may conflict with (#3421).

Tom

···

On Mon, Apr 20, 2015, 02:07 Kelvin Li <ltwisabc@…761…> wrote:

First ever patch submission. Here I propose cleaning up some unused variables

and imports.

Kelvin Li (2):

remove unused variable “cmd_split”

backends: remove unnecessary import statements

lib/matplotlib/backends/backend_agg.py | 2 –

lib/matplotlib/backends/backend_cairo.py | 5 +±-

lib/matplotlib/backends/backend_gdk.py | 9 -------

lib/matplotlib/backends/backend_gtk.py | 7 ++±-

lib/matplotlib/backends/backend_gtk3agg.py | 1 -

lib/matplotlib/backends/backend_gtk3cairo.py | 2 –

lib/matplotlib/backends/backend_gtkagg.py | 7 ±—

lib/matplotlib/backends/backend_gtkcairo.py | 3 —

lib/matplotlib/backends/backend_macosx.py | 11 ++±----

lib/matplotlib/backends/backend_mixed.py | 2 –

lib/matplotlib/backends/backend_nbagg.py | 2 –

lib/matplotlib/backends/backend_pgf.py | 2 –

lib/matplotlib/backends/backend_ps.py | 26 ++±---------------

lib/matplotlib/backends/backend_qt4.py | 36 +±-----------------------

lib/matplotlib/backends/backend_qt4agg.py | 11 --------

lib/matplotlib/backends/backend_qt5agg.py | 9 -------

lib/matplotlib/backends/backend_svg.py | 12 +++±----

lib/matplotlib/backends/backend_template.py | 4 —

lib/matplotlib/backends/backend_tkagg.py | 13 ++±------

lib/matplotlib/backends/backend_webagg.py | 1 -

lib/matplotlib/backends/backend_webagg_core.py | 4 —

lib/matplotlib/backends/backend_wx.py | 2 –

lib/matplotlib/backends/backend_wxagg.py | 9 ++±—

lib/matplotlib/backends/tkagg.py | 3 —

lib/matplotlib/backends/windowing.py | 2 –

lib/matplotlib/texmanager.py | 6 -----

26 files changed, 26 insertions(+), 165 deletions(-)

–

2.1.4

BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT

Develop your own process in accordance with the BPMN 2 standard

Learn Process modeling best practices with Bonita BPM through live exercises

http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_

source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF

Matplotlib-devel mailing list

Matplotlib-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/matplotlib-devel