(no subject)

Jae-Joon Lee <lee.j.joon@...83...> writes:

It seems as a bug in the pdf backend, which can be fixed by the simple
patch below. I didn't commit this fix as I think it would be better if
original author (Jouni?) make sure this is a correct way.

Your patch is correct - I probably
copy-pasted the cache code from
some other function and didn't pay
attention to what exactly is being
cached. I am unable to commit myself,
since I am traveling. Please feel free to
commit the fix.

ps. I didn't know that hatch is supported in pdf backend. The
documentation needs update.

Also the patch demo or some unit test
should cover that branch of the code,
ie the case when more than one patch
has the same hatch pattern.

By the way - do all backends support
arbitrary clip paths now? If so, the
hatch implementation of backend_ps
could perhaps be generalized to all
backends, or it could even be done in
the Patch class and not the backend.

Jouni

I just check in the patch with a slight change in the hatch_demo.py
Regards,

-JJ

···

On Sat, Dec 20, 2008 at 8:52 AM, jouni k seppänen <jks@...397...> wrote:

Also the patch demo or some unit test
should cover that branch of the code,
ie the case when more than one patch
has the same hatch pattern.

jouni k sepp�nen wrote:

By the way - do all backends support
arbitrary clip paths now? If so, the
hatch implementation of backend_ps
could perhaps be generalized to all
backends, or it could even be done in
the Patch class and not the backend.
  

That's a very good suggestion. All except Gdk support clip paths now. So supporting hatching everywhere is definitely something for the TODO list.

Mike

···

--
Michael Droettboom
Science Software Branch
Operations and Engineering Division
Space Telescope Science Institute
Operated by AURA for NASA