Hi,
I developed a new feature for the stackplot file that I needed and want to contribute this back to matplotlib. You can see the changes here:
https://github.com/JakobRohrhirsch/matplotlib/tree/stackplot_custom
I tried to follow the contribution guide but I’m not sure if I’m missing something (first time I’m contributing some code). Please let me know if I should send a pull request or if I should add some testing/anything else.
Best,
Jakob
I’d open a PR and see if folks think the feature is a good idea for core matplotlib. If they do, then you can add tests and docs. As a general good-proactice, its good to advertise exactly what your change does in the PR so folks understand what they are reviewing. Also be aware that a feature should not overly clutter the API, or lead to undue maintenance headaches down the road.
Cheers, Jody
On Aug 9, 2019, at 5:20 AM, Jakob Rohrhirsch jakob.rohrhirsch@gmail.com wrote:
Hi,
I developed a new feature for the stackplot file that I needed and want to contribute this back to matplotlib. You can see the changes here:
https://github.com/JakobRohrhirsch/matplotlib/tree/stackplot_custom
I tried to follow the contribution guide but I’m not sure if I’m missing something (first time I’m contributing some code). Please let me know if I should send a pull request or if I should add some testing/anything else.
Best,
Jakob
Matplotlib-devel mailing list
Matplotlib-devel@python.org
Matplotlib-devel Info Page