make.osx: should it set --prefix=$PREFIX ?

Fernando Garcia Bermudez
<fgb@...926...> writes:

I tested your changes (up to mpl_install_std) and merged the pull request.
Upon solving the binaries issue we could probably close this pull request.
Or we could open an issue for that particular matter.

Thanks; pull request #17 is IMHO ready for merging into v1.0.x, but
let's wait to see if anyone has further comments. I created pull request
#30 for merging into master; that one also has newer dependency versions
as suggested by Eric.

On master, I was able to almost run "make binaries", except somehow
bdist_mpkg didn't agree with the makefile about all the version numbers
in the mpkg filename, so hdiutil failed due to a missing input file. I
do think that problem is unrelated to these changes.

···

--
Jouni K. Sepp�nen
http://www.iki.fi/jks

Do you know if these changes will trickle to the py3 repo after merging into master? I initially came up with the patch while compiling the old py3k branch and when I realized it also applied to matplotlib Darren suggested I submit the pull request there. I’m asking this because there’s another tiny change that pertains to the py3 version of the patch and I wonder whether I should wait or start the pull process now.

– Fernando

···

On Sat, Mar 5, 2011 at 23:52, Jouni K. Seppänen <jks@…278…> wrote:

Thanks; pull request #17 is IMHO ready for merging into v1.0.x, but

let’s wait to see if anyone has further comments. I created pull request

#30 for merging into master; that one also has newer dependency versions

as suggested by Eric.