latex symbols as markers

Hi Mike,

Sorry the long delay in replying to your mail.

The changes look good, and it seems to produce good output.

There is just one small change I would make- since the markers are not quite properly centered on the points:

Index: lib/matplotlib/lines.py

···

===================================================================
— lib/matplotlib/lines.py (revision 8075)
+++ lib/matplotlib/lines.py (working copy)
@@ -898,7 +898,7 @@
height = ymax - ymin
max_dim = max(width, height)
path_trans = Affine2D() \

  •        .translate(0.5 * -width, 0.5 * -height) \
    
  •        .translate(-xmin+0.5 * -width, -ymin+0.5 * -height)\
           .scale((renderer.points_to_pixels(self.get_markersize()) / max_dim))
    

On Tue, Dec 22, 2009 at 4:44 PM, Michael Droettboom <mdroe@…31…> wrote:

It’s been a while – just curious if you’ve had any more thoughts on this. I’m considering committing your changes + my suggestions, since what’s there is working pretty well.

Mike

tcb wrote:

On Mon, Nov 2, 2009 at 3:47 PM, Michael Droettboom <mdroe@…31… mailto:mdroe@...31...> wrote:

Thanks for all this work.  It looks great.



Do you mind if we bring this conversation back to the list?  I

think others may have some additional feedback, but I don't want

to Cc the list without your permission.

Hi Mike,

sure- the discussion should go back to the list- I thought it might be better to get your feedback on it first.

your comments are interesting, and I’ll take a closer look later on today…

tcb

Michael Droettboom

Science Software Branch

Operations and Engineering Division

Space Telescope Science Institute

Operated by AURA for NASA

Good point. Fixed in r8076.

Cheers,
Mike

tcb wrote:

···

Hi Mike,

Sorry the long delay in replying to your mail.

The changes look good, and it seems to produce good output.

There is just one small change I would make- since the markers are not quite properly centered on the points:

Index: lib/matplotlib/lines.py

--- lib/matplotlib/lines.py (revision 8075)
+++ lib/matplotlib/lines.py (working copy)
@@ -898,7 +898,7 @@
         height = ymax - ymin
         max_dim = max(width, height)
         path_trans = Affine2D() \
- .translate(0.5 * -width, 0.5 * -height) \
+ .translate(-xmin+0.5 * -width, -ymin+0.5 * -height)\
             .scale((renderer.points_to_pixels(self.get_markersize()) / max_dim))

On Tue, Dec 22, 2009 at 4:44 PM, Michael Droettboom <mdroe@…31… > <mailto:mdroe@…31…>> wrote:

    It's been a while -- just curious if you've had any more thoughts
    on this. I'm considering committing your changes + my
    suggestions, since what's there is working pretty well.

    Mike

    tcb wrote:

        On Mon, Nov 2, 2009 at 3:47 PM, Michael Droettboom > <mdroe@…31… <mailto:mdroe@…31…> > <mailto:mdroe@…31…>> wrote:

           Thanks for all this work. It looks great.

           Do you mind if we bring this conversation back to the list? I
           think others may have some additional feedback, but I don't
        want
           to Cc the list without your permission.

        Hi Mike,

        sure- the discussion should go back to the list- I thought it
        might be better to get your feedback on it first.

        your comments are interesting, and I'll take a closer look
        later on today...

        tcb

    -- Michael Droettboom
    Science Software Branch
    Operations and Engineering Division
    Space Telescope Science Institute
    Operated by AURA for NASA

--
Michael Droettboom
Science Software Branch
Operations and Engineering Division
Space Telescope Science Institute
Operated by AURA for NASA