I came across this Python syntax bug in matplotlib.figure.add_subplot:
raise ValueError(
"polar=True, yet projection=’%s’. " +
“Only one of these arguments should be supplied.” %
projection)
If that code ever executes it will fail with “TypeError: not all arguments converted during string formatting”.
It’s trivial to fix, of course, (just delete the ‘+’) but I don’t know how to submit a patch. Could someone please show me?
TIA!
~kj
Good catch. I can make the change if you want. However, if you want to
use as a learning experience, first make a copy of the original file,
say figure.py.orig. Then make the changes to your figure.py. Then you
need to run diff:
diff -u figure.py.orig figure.py > patchname.diff
Ryan
On Sat, Oct 23, 2010 at 1:37 PM, Kynn Jones <kynnjo@...149...> wrote:
I came across this Python syntax bug in matplotlib.figure.add_subplot:
raise ValueError(
"polar=True, yet projection='%s'. " +
"Only one of these arguments should be supplied." %
projection)
If that code ever executes it will fail with "TypeError: not all arguments
converted during string formatting".
It's trivial to fix, of course, (just delete the '+') but I don't know how
to submit a patch. Could someone please show me?
--
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma
OK, got that part. Thanks. But where do I send the patch?
~kj
On Sat, Oct 23, 2010 at 3:13 PM, Ryan May <rmay31@…714…> wrote:
On Sat, Oct 23, 2010 at 1:37 PM, Kynn Jones <kynnjo@…149…> wrote:
I came across this Python syntax bug in matplotlib.figure.add_subplot:
raise ValueError("polar=True, yet projection='%s'. " +"Only one of these arguments should be supplied." %projection)If that code ever executes it will fail with "TypeError: not all arguments
converted during string formatting".
It’s trivial to fix, of course, (just delete the ‘+’) but I don’t know how
to submit a patch. Could someone please show me?
Good catch. I can make the change if you want. However, if you want to
use as a learning experience, first make a copy of the original file,
say figure.py.orig. Then make the changes to your figure.py. Then you
need to run diff:
diff -u figure.py.orig figure.py > patchname.diff
Actually, we recommend submitting an svn diff. Details at:
http://matplotlib.sourceforge.net/faq/howto_faq.html#submit-a-patch
JDH
On Mon, Oct 25, 2010 at 6:53 AM, Kynn Jones <kynnjo@...149...> wrote:
diff -u figure.py.orig figure.py > patchname.diff
OK, got that part. Thanks. But where do I send the patch?