ft2font.cpp memory fix patch not in 1.1.x branch

Hi,

We are (I think) running into a memory leak that should be resolved by

https://github.com/matplotlib/matplotlib/commit
/98ee4e991ae142622f3814db193b75236eb77cea#src/ft2font.cpp

It was commited in March, but seems not to have made its way to the 1.1.x
branch. Would it be possible for a maintainer to apply it to the release branch?

Thanks
Neilen

Hmm, strange…

It isn’t even in master right now. The last changes to it were by Michael Droettboom (commit 6b643862) in June of 2010, but the commit you are pointing to was done in March of 2011… this needs more investigating.

Ben Root

···

On Thu, Dec 1, 2011 at 9:29 AM, Neilen Marais <nmarais@…3871…> wrote:

https://github.com/matplotlib/matplotlib/commit

/98ee4e991ae142622f3814db193b75236eb77cea#src/ft2font.cpp

Strange, I could have sworn that I rebased my master branch correctly. Now, the fix is showing in master. Well, now that that has been resolved, I guess we can just simply cherry-pick that commit into v1.1.x?

Ben Root

···

On Thu, Dec 1, 2011 at 10:14 AM, Benjamin Root <ben.root@…3146…4…> wrote:

On Thu, Dec 1, 2011 at 9:29 AM, Neilen Marais <nmarais@…3870…> wrote:

https://github.com/matplotlib/matplotlib/commit

/98ee4e991ae142622f3814db193b75236eb77cea#src/ft2font.cpp

Hmm, strange…

It isn’t even in master right now. The last changes to it were by Michael Droettboom (commit 6b643862) in June of 2010, but the commit you are pointing to was done in March of 2011… this needs more investigating.

Ben Root

It looks like this is already on 1.1.x, but not in the 1.1.0
release. Or am I missing something?

Mike
···

http://p.sf.net/sfu/splunk-novd2dMatplotlib-users@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/matplotlib-users

Heh, strange… I could have sworn that the reference counter decrements were there… Ok, looks like everything is where it should be, I guess.

Ben Root

···

On Mon, Dec 5, 2011 at 1:44 PM, Michael Droettboom <mdroe@…86…> wrote:

It looks like this is already on 1.1.x, but not in the 1.1.0

release. Or am I missing something?

Mike




On 12/01/2011 12:24 PM, Benjamin Root wrote:
    On Thu, Dec 1, 2011 at 10:14 AM, Benjamin > > Root <ben.root@...1304...> > >         wrote:
        On Thu, Dec 1, 2011 at 9:29 AM, > > > Neilen Marais <nmarais@...3870...> > > >             wrote:

https://github.com/matplotlib/matplotlib/commit

          /98ee4e991ae142622f3814db193b75236eb77cea#src/ft2font.cpp
      Hmm, strange...



      It isn't even in master right now.  The last changes to it

were by Michael Droettboom (commit 6b643862) in June of 2010,
but the commit you are pointing to was done in March of
2011… this needs more investigating.

      Ben Root
            Strange, I could have

sworn that I rebased my master branch correctly. Now, the fix
is showing in master. Well, now that that has been resolved,
I guess we can just simply cherry-pick that commit into
v1.1.x?

      Ben Root
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense.
[http://p.sf.net/sfu/splunk-novd2d](http://p.sf.net/sfu/splunk-novd2d)
_______________________________________________
Matplotlib-users mailing list
Matplotlib-users@lists.sourceforge.net
[https://lists.sourceforge.net/lists/listinfo/matplotlib-users](https://lists.sourceforge.net/lists/listinfo/matplotlib-users)

All the data continuously generated in your IT infrastructure

contains a definitive record of customers, application performance,

security threats, fraudulent activity, and more. Splunk takes this

data and makes sense of it. IT sense. And common sense.

http://p.sf.net/sfu/splunk-novd2d


Matplotlib-users mailing list

Matplotlib-users@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/matplotlib-users

You’re not crazy. The v1.1.x branch got inadvertently moved to
master yesterday. On the v1.1.x branch this fix is not applied. I
will do so now.

Mike
···
-- Michael Droettboom
Science Software Branch
Space Telescope Science Institute
Baltimore, Maryland, USA