Comparing pdf output in tests

Andrew Straw <strawman@...36...> writes:

Sorry for not noticing this earlier, but I'm looking in the baseline
image directory, and I see a bunch of *_pdf.png files. I guess these
have been convered to png from pdf on the tester's machine. Do you think
it makes more sense to have the .pdf files in the test repo and convert
to png at test run time? This way we don't become dependent on gs
rendering quirks or differences across pdf renderers. Maybe the files
are also smaller.

That's exactly how it works now, isn't it? You are seeing the *_pdf.png
files because those get produced while running the tests from the *.pdf
files, and they are not checked into the svn repository.

···

--
Jouni K. Seppänen

Jouni K. Seppänen wrote:

Andrew Straw <strawman@...36...> writes:

Sorry for not noticing this earlier, but I'm looking in the baseline
image directory, and I see a bunch of *_pdf.png files. I guess these
have been convered to png from pdf on the tester's machine. Do you think
it makes more sense to have the .pdf files in the test repo and convert
to png at test run time? This way we don't become dependent on gs
rendering quirks or differences across pdf renderers. Maybe the files
are also smaller.
    
That's exactly how it works now, isn't it? You are seeing the *_pdf.png
files because those get produced while running the tests from the *.pdf
files, and they are not checked into the svn repository.
  

Sorry for the false alarm. My image browser was showing the .png and
.svg files, but not the .pdfs for some reason. I assumed it was showing
all the files in the directory, which lead to this false conclusion.

-Andrew