Closing in on 1.3.0 release candidate

In article <51A51603.5030106@...31...>,
Michael Droettboom <mdroe@...31...>
wrote:

I am going to hold off one more day on making the release candidate.
There are three blocker bugs that were discovered over the weekend and
I'd like to give them a chance for review first:...

Thanks for the update.

The Mac version built fine, but I saw several warnings. The only one I'm
worried about is use of a deprecated Numpy API:

In file included from src/_backend_agg.cpp:12:
In file included from src/_backend_agg.h:43:
In file included from src/agg_py_path_iterator.h:7:
In file included from
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/arrayobject.h:15:
In file included from
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/ndarrayobject.h:17:
In file included from
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/ndarraytypes.h:1728:
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/npy_deprecated_api.h:11:2: warning: "Using
deprecated NumPy API, disable it by
      #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-W#warnings]
#warning "Using deprecated NumPy API, disable it by #defining
NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

These look innocuous, but easy to fix:

./CXX/Python2/Objects.hxx:1133:23: warning: implicit conversion of NULL
constant to 'int' [-Wnull-conversion]
            , offset( NULL )
                    ~ ^~~~

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/npy_3kcompat.h:247:40: warning: conversion
from string literal to 'char *' is
      deprecated [-Wdeprecated-writable-strings]
    return PyObject_CallFunction(open, "Os", filename, mode);

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/npy_3kcompat.h:255:37: warning: conversion
from string literal to 'char *' is
      deprecated [-Wdeprecated-writable-strings]
    ret = PyObject_CallMethod(file, "close", NULL);

These are tricky, as we want to continue to support earlier versions of Numpy. (Officially, we support back to 1.4, though only 1.6 and later is getting regular testing). Last time I looked, there wasn't a good way to do this without a lot of #ifdefs that would just make the maintenance more complicated.

However, perhaps for the next major release we should consider dropping Numpy < 1.5 and fixing up these deprecation warnings.

Mike

···

On 05/29/2013 05:23 PM, Russell E. Owen wrote:

In article <51A51603.5030106@...31...>,
  Michael Droettboom <mdroe@...31...>
  wrote:

I am going to hold off one more day on making the release candidate.
There are three blocker bugs that were discovered over the weekend and
I'd like to give them a chance for review first:...

Thanks for the update.

The Mac version built fine, but I saw several warnings. The only one I'm
worried about is use of a deprecated Numpy API:

In file included from src/_backend_agg.cpp:12:
In file included from src/_backend_agg.h:43:
In file included from src/agg_py_path_iterator.h:7:
In file included from
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/arrayobject.h:15:
In file included from
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/ndarrayobject.h:17:
In file included from
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/ndarraytypes.h:1728:
/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/npy_deprecated_api.h:11:2: warning: "Using
deprecated NumPy API, disable it by
       #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-W#warnings]
#warning "Using deprecated NumPy API, disable it by #defining
NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

These look innocuous, but easy to fix:

./CXX/Python2/Objects.hxx:1133:23: warning: implicit conversion of NULL
constant to 'int' [-Wnull-conversion]
             , offset( NULL )
                     ~ ^~~~

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/npy_3kcompat.h:247:40: warning: conversion
from string literal to 'char *' is
       deprecated [-Wdeprecated-writable-strings]
     return PyObject_CallFunction(open, "Os", filename, mode);

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-pack
ages/numpy/core/include/numpy/npy_3kcompat.h:255:37: warning: conversion
from string literal to 'char *' is
       deprecated [-Wdeprecated-writable-strings]
     ret = PyObject_CallMethod(file, "close", NULL);