agg::rect errors

CVS is giving compile errors in several of the cpp

    > backend files: error: `agg::rect' is not a template

    > I think these should be `agg::rect_base' instead.
    > Changing that makes it compile fine. Since I have never
    > messed with these files I thought I would post to the
    > list instead of committing the changes myself.

In agg23/include/agg_basics.h you have

  typedef rect_base<int> rect; //----rec

So its either

  agg::rect r;

or

  agg::rect_base<int> r;

But strangely, I am not encountering any compile problems on my end.
I did a fair amount of work in the agg backend yesterday, I just
committed my tree, It may be that this problem will disappear after
you resync. If not, feel free to commit any needed fixes.

Thanks,
JDH

I resynced and still had the problem. I committed this change which
makes everything happy for me.

cvs diff: Diffing .
Index: _backend_agg.cpp

···

===================================================================
RCS file: /cvsroot/matplotlib/matplotlib/src/_backend_agg.cpp,v
retrieving revision 1.81
diff -r1.81 _backend_agg.cpp
677c677
< agg::rect<int> rect( (int)l, height-(int)t, (int)r, height-(int)b ) ;
---

  agg::rect rect( (int)l, height-(int)t, (int)r, height-(int)b ) ;

Index: _backend_agg.h

RCS file: /cvsroot/matplotlib/matplotlib/src/_backend_agg.h,v
retrieving revision 1.22
diff -r1.22 _backend_agg.h
162c162
< agg::rect<int> bbox_to_rect( const Py::Object& o);
---

  agg::rect bbox_to_rect( const Py::Object& o);

- Charlie

John Hunter wrote:

"Charles" == Charles Moad <cmoad@...209...> writes:

    > CVS is giving compile errors in several of the cpp
    > backend files: error: `agg::rect' is not a template

    > I think these should be `agg::rect_base' instead.
    > Changing that makes it compile fine. Since I have never
    > messed with these files I thought I would post to the
    > list instead of committing the changes myself.

In agg23/include/agg_basics.h you have

  typedef rect_base<int> rect; //----rec

So its either

  agg::rect r;

or

  agg::rect_base<int> r;

But strangely, I am not encountering any compile problems on my end.
I did a fair amount of work in the agg backend yesterday, I just
committed my tree, It may be that this problem will disappear after
you resync. If not, feel free to commit any needed fixes.

Thanks,
JDH