0.99 release candidate this weekend

Development matplotlib-devel
1

Sorry I fell behind and did not get a release out earlier as I
intended. I am going to take another stab this weekend so we can have
something by scipy. Please commit anything you need to before the
release, and I will ask Michael to create the release branch tomorrow.
There will still be ample time for testing and fixing stuff from the
release branch, but this will be done on the branch rather than the
trunk. Tentative schedule:

  * branch tomorrow

  * src candidate Sunday

  * win32 and osx binaries for testing monday

  * official release late next week

JDH

2

Sorry for reposting, but the original may have been overlooked since it was buried deep in a matplotlib-users thread.

Currently, `pyplot.rgrids` is returning tick lines instead of grid lines. My guess is that this is a typo, but there may be a compelling reason to return the tick lines. If it is a typo, here's a patch:

Index: lib/matplotlib/projections/polar.py

···

===================================================================
--- lib/matplotlib/projections/polar.py (revision 7300)
+++ lib/matplotlib/projections/polar.py (working copy)
@@ -397,7 +397,7 @@
         self._r_label2_position.clear().translate(angle, -self._rpad * rmax)
         for t in self.yaxis.get_ticklabels():
             t.update(kwargs)
- return self.yaxis.get_ticklines(), self.yaxis.get_ticklabels()
+ return self.yaxis.get_gridlines(), self.yaxis.get_ticklabels()

     set_rgrids.__doc__ = cbook.dedent(set_rgrids.__doc__) % kwdocd

3

Doesn't pyplot.rgrids need to be fixed too:

def rgrids(*args, **kwargs):
    """
    Set/Get the radial locations of the gridlines and ticklabels on a
    polar plot.

    call signatures::

      lines, labels = rgrids()
      lines, labels = rgrids(radii, labels=None, angle=22.5, **kwargs)

    When called with no arguments, :func:`rgrid` simply returns the
    tuple (*lines*, *labels*), where *lines* is an array of radial
    gridlines (:class:`~matplotlib.lines.Line2D` instances) and
    *labels* is an array of tick labels
    (:class:`~matplotlib.text.Text` instances). When called with
    arguments, the labels will appear at the specified radial
    distances and angles.

    *labels*, if not *None*, is a len(*radii*) list of strings of the
    labels to use at each angle.

    If *labels* is None, the rformatter will be used

    Examples::

      # set the locations of the radial gridlines and labels
      lines, labels = rgrids( (0.25, 0.5, 1.0) )

      # set the locations and labels of the radial gridlines and labels
      lines, labels = rgrids( (0.25, 0.5, 1.0), ('Tom', 'Dick', 'Harry' )

    """
    ax = gca()
    if not isinstance(ax, PolarAxes):
        raise RuntimeError('rgrids only defined for polar axes')
    if len(args)==0:
        lines = ax.yaxis.get_ticklines()
        labels = ax.yaxis.get_ticklabels()
    else:

Should

  lines = ax.yaxis.get_ticklines()

be

  lines = ax.yaxis.get_gridlines()

I'm going to make both these changes in svn , but I'd like you to confirm this.

JDH

···

On Thu, Jul 30, 2009 at 10:01 AM, Tony Yu<tsyu80@...149...> wrote:

Sorry for reposting, but the original may have been overlooked since
it was buried deep in a matplotlib-users thread.

Currently, `pyplot.rgrids` is returning tick lines instead of grid
lines. My guess is that this is a typo, but there may be a compelling
reason to return the tick lines. If it is a typo, here's a patch:

4

Sorry for sending this twice, John; I forgot to copy the list.

Sorry for reposting, but the original may have been overlooked since
it was buried deep in a matplotlib-users thread.

Currently, pyplot.rgrids is returning tick lines instead of grid
lines. My guess is that this is a typo, but there may be a compelling
reason to return the tick lines. If it is a typo, here’s a patch:

Doesn’t pyplot.rgrids need to be fixed too:

def rgrids(*args, **kwargs):
“”"
[Snip]

Should

lines = ax.yaxis.get_ticklines()

be

lines = ax.yaxis.get_gridlines()

I’m going to make both these changes in svn , but I’d like you to confirm this.

Yes, that’s correct. I called rgrids with arguments so I completely missed that call to get_ticklines. However, I think there’s a typo in svn: yaxis.gridlines is called instead of yaxis.get_gridlines().

-T

Index: lib/matplotlib/pyplot.py

···

On Jul 31, 2009, at 9:14 AM, John Hunter wrote:

On Thu, Jul 30, 2009 at 10:01 AM, Tony Yu<tsyu80@…149…> wrote:
===================================================================
— lib/matplotlib/pyplot.py (revision 7313)
+++ lib/matplotlib/pyplot.py (working copy)
@@ -1102,7 +1102,7 @@
if not isinstance(ax, PolarAxes):
raise RuntimeError(‘rgrids only defined for polar axes’)
if len(args)==0:

  •    lines = ax.yaxis.gridlines()

  •    lines = ax.yaxis.get_gridlines()
  labels = ax.yaxis.get_ticklabels()
    else:
    lines, labels = ax.set_rgrids(*args, **kwargs)
5

Oops, thanks for catching that. Fixed in svn

···

On Fri, Jul 31, 2009 at 8:25 AM, Tony Yu<tsyu80@...149...> wrote:

Yes, that's correct. I called `rgrids` with arguments so I completely missed
that call to `get_ticklines`. However, I think there's a typo in svn:
yaxis.gridlines is called instead of yaxis.get_gridlines().

6

Michael, if you have time today, would you make the 0.99 release
branch, update doc/devel/coding_guide.rst with instructions on how to
check out the branch (basically just change the version numbers so
people are pointed to the current branch), and paste those
instructions here so developers can easily grab the release branch?

Thanks,
JDH

···

On Thu, Jul 30, 2009 at 9:46 AM, John Hunter<jdh2358@...149...> wrote:

Sorry I fell behind and did not get a release out earlier as I
intended. I am going to take another stab this weekend so we can have
something by scipy. Please commit anything you need to before the
release, and I will ask Michael to create the release branch tomorrow.
There will still be ample time for testing and fixing stuff from the
release branch, but this will be done on the branch rather than the
trunk. Tentative schedule:

* branch tomorrow